Callbacks for client reset have been restored #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
approved these changes
Oct 24, 2023
|
Appears all the tests are failing consistently |
Co-authored-by: LJ <[email protected]>
…neth/client-reset
This reverts commit 8067b07.
This reverts commit fc1d246.
kneth
force-pushed
the
kneth/client-reset
branch
from
8b9937a to
9a681c0
Compare
kneth
force-pushed
the
kneth/client-reset
branch
from
9a681c0 to
f0a9f32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The callbacks were not fired. The root cause was that they have not been exposed to the binding. Unfortunately the flexible sync tests are still timing out since the function
triggerClientResetis not able to trigger it on the sync server. To make the function more robust, a retry mechanism is implemented (it is believed that the trigger will sometimes fail due to a race condition in the server).This closes #6201
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary